testcluster: don't overwrite localities indiscriminately #40451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
reviewed
Sep 4, 2019
There was a problem hiding this comment.
Ah nice! You saw my annoyed comment in that test. This looks good to me, but wait for someone else who knows the code better.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andy-kimball, @darinpp, and @rohany)
andreimatei
force-pushed
the
testcluster.localities
branch
from
3d70757
to
c114113
Compare
|
bors r+ |
Build failed |
craig bot
pushed a commit
that referenced
this pull request
Sep 5, 2019
40436: sql: more test fixes for opt-driven foreign keys r=RaduBerinde a=RaduBerinde Fixing up some expected errors in tests and making sure we don't buffer the mutation input if we fall back to the legacy path (the bufferNode is unnecessary and interferes with an interleaved delete fast path). Release note: None 40451: testcluster: don't overwrite localities indiscriminately r=andreimatei a=andreimatei Before this patch, a TestCluster would set localities for all nodes to a static values. This was overwriting any values set throught the TestClusterArgs. This patch makes it so that, if any localities are set in the args, we don't overwrite them. Release note: None 40485: sql: Fix a bug with ordinal_position in information_schema.columns r=arulajmani a=arulajmani When a column other than the last is dropped, ordinal_position in information_schema.columns virtual table no longer matches attnum from the pg_attribute table. This PR fixes this issue. Fixes #39787 Release note (bug fix): ordinal_position in information_schema.columns matches pg_attribute.attnum after a column is dropped. 40511: exec: fix explain(vec) for queries with subqueries r=jordanlewis a=jordanlewis Also add logic tests that show the explain(vec) plans for all of the tpch queries. Closes #40484. Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Andrei Matei <andrei@cockroachlabs.com> Co-authored-by: Arul Ajmani <arula@cockroachlabs.com> Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build failed (retrying...) |
Merge conflict (retrying...) |
Merge conflict |
Before this patch, a TestCluster would set localities for all nodes to a static values. This was overwriting any values set throught the TestClusterArgs. This patch makes it so that, if any localities are set in the args, we don't overwrite them. Release note: None
andreimatei
force-pushed
the
testcluster.localities
branch
from
c114113
to
4577e13
Compare
andreimatei
commented
Sep 6, 2019
There was a problem hiding this comment.
bors r+
Reviewable status:
craig bot
pushed a commit
that referenced
this pull request
Sep 6, 2019
40451: testcluster: don't overwrite localities indiscriminately r=andreimatei a=andreimatei Before this patch, a TestCluster would set localities for all nodes to a static values. This was overwriting any values set throught the TestClusterArgs. This patch makes it so that, if any localities are set in the args, we don't overwrite them. Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Build succeeded |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, a TestCluster would set localities for all nodes to a
static values. This was overwriting any values set throught the
TestClusterArgs. This patch makes it so that, if any localities are set
in the args, we don't overwrite them.
Release note: None