importccl: replace the undocumented data format MYSQLOUTFILE with DELIMITED #40482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
MYSQLOUTFILE was originally used to help a client import data that was not in csv proper format. This turns out to be useful for other users so we call the new format DELIMITED. It's very fast and simple format for importing delimited data disregarding issues with quoting. For example the csv format forbids `field1,fieldsth2` as such fields that contain quotes have to be enclosed in quotes themselves. The whole format is fully described here https://dev.mysql.com/doc/refman/8.0/en/load-data.html. Fixes cockroachdb#39820. Release note (cli change): add a new IMPORT DATA format DELIMITED.
spaskob
force-pushed
the
mysqloutfile-to-delimited
branch
from
9ad90b3
to
3c3cece
Compare
dt
approved these changes
Sep 4, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 4, 2019
40469: opt: fix panic when building indirection exprs r=justinj a=justinj Previously, we would ask a built array datum to tell us its type when building an IndirectionExpr. This was problematic when the datum was NULL, since while the optimizer-level NULLs track their inferred type, built DNulls do not, so we ended up not knowing the element type. This is fixed by grabbing the type from the opt expression, rather than the built datum. Fixes #40404. Fixes #37794. Release note (bug fix): fixed an optimizer panic when building array access expressions. 40471: exec: add projections of AndExpr r=jordanlewis a=jordanlewis This adds support for TPCH q19, which sees a 3x speedup with vectorized. Release note: None 40482: importccl: replace the undocumented data format MYSQLOUTFILE with DELIMITED r=spaskob a=spaskob MYSQLOUTFILE was originally used to help a client import data that was not in csv proper format. This turns out to be useful for other users so we call the new format DELIMITED. It's very fast and simple format for importing delimited data disregarding issues with quoting. For example the csv format forbids `field1,fieldsth2` as such fields that contain quotes have to be enclosed in quotes themselves. The whole format is fully described here https://dev.mysql.com/doc/refman/8.0/en/load-data.html. Fixes #39820. Release note (cli change): add a new IMPORT DATA format DELIMITED. Co-authored-by: Justin Jaffray <justin@cockroachlabs.com> Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com> Co-authored-by: Spas Bojanov <spas@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MYSQLOUTFILE was originally used to help a client import data that was
not in csv proper format. This turns out to be useful for other users so
we call the new format DELIMITED. It's very fast and simple format for importing
delimited data disregarding issues with quoting. For example the csv format forbids
field1,fieldsth2as such fields that contain quotes have to be enclosed inquotes themselves. The whole format is fully described here
https://dev.mysql.com/doc/refman/8.0/en/load-data.html.
Fixes #39820.
Release note (cli change): add a new IMPORT DATA format DELIMITED.