exec: Bug fixes in vectorized casts #40495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@jordanlewis this should fix that decimal casting business. I think when we flipped the fromtyp to totype it was somehow reading decimals in as floats and things were going wrong. |
|
re #40461, i can't repro this on here, but I'll try again tomorrow on a GCE worker. |
jordanlewis
approved these changes
Sep 5, 2019
|
JK, i was able to repo #40461 on this branch :(. This is still should fix the problems you were having. bors r+ |
Build failed |
|
bors r+ |
|
bors r- |
Canceled |
rohany
force-pushed
the
cast-template-fix
branch
from
f13f9c2
to
5a882d1
Compare
|
@jordanlewis PTAL on this pr -- based on the templating it made more sense to do both changes here. |
rohany
changed the title
* Fixed a bug where the appropriate setters and getters were not being generated for the casts. * Fixed a bug where columns were not getting sliced, causing column length mismatches. Fixes cockroachdb#40461. Release note: None
rohany
force-pushed
the
cast-template-fix
branch
from
5a882d1
to
8bb4562
Compare
jordanlewis
approved these changes
Sep 5, 2019
|
I can’t right now, due to every supported cast having the same set, get and slice operators :( |
jordanlewis
approved these changes
Sep 5, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 5, 2019
40495: exec: Bug fixes in vectorized casts r=rohany a=rohany * Fixed a bug where the appropriate setters and getters were not being generated for the casts. * Fixed a bug where columns were not getting sliced, causing column length mismatches. Fixes #40461. Release note: None Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the appropriate setters and getters were not being
generated for the casts.
Fixed a bug where columns were not getting sliced, causing column
length mismatches.
Fixes #40461.
Release note: None