sql: fix table lookup for drop index #40516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, when searching for the table relevant to a particular index when dropping the index, we would fetch all object names and require that all those tables exist. However, if a table was deleted in the same transaction that table name would not be resolvable and we would error. We already had a check to see if the table being looked up was nil, but this check would not be used because the `required` flag was set to true. This PR just sets the flag to false, and looks at moves on to the next table if one of them no longer is resolvable. Release note (bug fix): Fix faulty error when trying to delete a table and an unrelated index in the same transaction.
pbardea
force-pushed
the
index-search-required
branch
from
1f06c92
to
c224caf
Compare
pbardea
changed the title
dt
approved these changes
Sep 5, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 5, 2019
40485: sql: Fix a bug with ordinal_position in information_schema.columns r=arulajmani a=arulajmani When a column other than the last is dropped, ordinal_position in information_schema.columns virtual table no longer matches attnum from the pg_attribute table. This PR fixes this issue. Fixes #39787 Release note (bug fix): ordinal_position in information_schema.columns matches pg_attribute.attnum after a column is dropped. 40511: exec: fix explain(vec) for queries with subqueries r=jordanlewis a=jordanlewis Also add logic tests that show the explain(vec) plans for all of the tpch queries. Closes #40484. Release note: None 40516: sql: fix table lookup for drop index r=pbardea a=pbardea Previously, when searching for the table relevant to a particular index when dropping the index, we would fetch all object names and require that all those tables exist. However, if a table was deleted in the same transaction that table name would not be resolvable and we would error. We already had a check to see if the table being looked up was nil, but this check would not be used because the `required` flag was set to true. This PR just sets the flag to false, and looks at moves on to the next table if one of them no longer is resolvable. Addresses #38768. Release note (bug fix): Fix faulty error when trying to delete a table and an unrelated index in the same transaction. Co-authored-by: Arul Ajmani <arula@cockroachlabs.com> Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com> Co-authored-by: Paul Bardea <pbardea@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when searching for the table relevant to a particular index
when dropping the index, we would fetch all object names and require that
all those tables exist. However, if a table was deleted in the same
transaction that table name would not be resolvable and we would error.
We already had a check to see if the table being looked up was nil, but
this check would not be used because the
requiredflag was set to true.This PR just sets the flag to false, and looks at moves on to the next
table if one of them no longer is resolvable.
Addresses #38768.
Release note (bug fix): Fix faulty error when trying to delete a table
and an unrelated index in the same transaction.