Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distsqlrun: make indexJoiner and joinReader show up in EXPLAIN (VEC) #40560

Merged
merged 1 commit into from
Sep 7, 2019

Conversation

yuzefovich
Copy link
Member

Previously, the columnarizer was the end of the chain of operators
that would show up in the output of EXPLAIN (VEC). In particular,
we wrap index joiner and join reader with a columnarizer-materializer
pair, so those although present, would not be seen in the output.
Now this is fixed.

Release note: None

@yuzefovich yuzefovich requested review from jordanlewis and a team September 6, 2019 20:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Previously, the columnarizer was the end of the chain of operators
that would show up in the output of EXPLAIN (VEC). In particular,
we wrap index joiner and join reader with a columnarizer-materializer
pair, so those although present, would not be seen in the output.
Now this is fixed.

Release note: None
@yuzefovich
Copy link
Member Author

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Sep 7, 2019
40560: distsqlrun: make indexJoiner and joinReader show up in EXPLAIN (VEC) r=yuzefovich a=yuzefovich

Previously, the columnarizer was the end of the chain of operators
that would show up in the output of EXPLAIN (VEC). In particular,
we wrap index joiner and join reader with a columnarizer-materializer
pair, so those although present, would not be seen in the output.
Now this is fixed.

Release note: None

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Sep 7, 2019

Build succeeded

@craig craig bot merged commit efcdb10 into cockroachdb:master Sep 7, 2019
@yuzefovich yuzefovich deleted the fix-explain-vec branch September 10, 2019 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants