sqlmigrations: really skip baked-in migrations when asked to skip them #40567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnsureMigrations() optinally can be told to skip the migrations that are included in the bootstrap schema when the node running the migrations has just bootstraped the cluster. Except the mechanism wasn't actually skipping them. This patch fixes that. There are two places in that function where we check if we can skip a migration, and only one of them was correct. The whole idea of skipping these migrations is arguable because the check only applies to the node that bootstrapped the cluster. All the other nodes will still run them. So I can also get rid of the thing if reviewers ask. Release note: None
|
This change is |
|
Bors r+
…On Fri, Sep 6, 2019, 8:06 PM Jordan Lewis ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40567?email_source=notifications&email_token=AAC4C4MAZB5AXD5CWVOFRD3QILV7PA5CNFSM4IUOCH6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD7PCGQ#pullrequestreview-285143322>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC4C4JAGPE2ZMVAEMCLOPTQILV7PANCNFSM4IUOCH6A>
.
|
craig bot
pushed a commit
that referenced
this pull request
Sep 7, 2019
40567: sqlmigrations: really skip baked-in migrations when asked to skip them r=andreimatei a=andreimatei EnsureMigrations() optinally can be told to skip the migrations that are included in the bootstrap schema when the node running the migrations has just bootstraped the cluster. Except the mechanism wasn't actually skipping them. This patch fixes that. There are two places in that function where we check if we can skip a migration, and only one of them was correct. The whole idea of skipping these migrations is arguable because the check only applies to the node that bootstrapped the cluster. All the other nodes will still run them. So I can also get rid of the thing if reviewers ask. Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnsureMigrations() optinally can be told to skip the migrations that are
included in the bootstrap schema when the node running the migrations
has just bootstraped the cluster. Except the mechanism wasn't actually
skipping them. This patch fixes that. There are two places in that
function where we check if we can skip a migration, and only one of them
was correct.
The whole idea of skipping these migrations is arguable because the
check only applies to the node that bootstrapped the cluster. All the
other nodes will still run them. So I can also get rid of the thing if
reviewers ask.
Release note: None