roachtest: run fewer TPHC imports, increase timeout #40582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The TPCH import roachtest has been timing out for quite a while. Running it by hand, it appears it _is_ making progress when it times out, which suggests it has become slower since the timeouts were picked, which seems to be supported by comments claiming it used to run in 3h with 8 nodes. Exactly why it is slower and how to fix it is something that will require further study, but in the meantime its constant failures aren't useful and contribute to overall test flakiness. Until we have a chance to dig into this further, this removes the 4 and 32 node configurations and gives the remaining 8-node test 50% longer to complete. Release note: none.
thoszhang
approved these changes
Sep 9, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 9, 2019
40582: roachtest: run fewer TPHC imports, increase timeout r=dt a=dt The TPCH import roachtest has been timing out for quite a while. Running it by hand, it appears it _is_ making progress when it times out, which suggests it has become slower since the timeouts were picked, which seems to be supported by comments claiming it used to run in 3h with 8 nodes. Exactly why it is slower and how to fix it is something that will require further study, but in the meantime its constant failures aren't useful and contribute to overall test flakiness. Until we have a chance to dig into this further, this removes the 4 and 32 node configurations and gives the remaining 8-node test 50% longer to complete. Release note: none. Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TPCH import roachtest has been timing out for quite a while. Running it by hand, it appears it
is making progress when it times out, which suggests it has become slower since the timeouts were
picked, which seems to be supported by comments claiming it used to run in 3h with 8 nodes. Exactly
why it is slower and how to fix it is something that will require further study, but in the meantime
its constant failures aren't useful and contribute to overall test flakiness. Until we have a chance
to dig into this further, this removes the 4 and 32 node configurations and gives the remaining 8-node
test 50% longer to complete.
Release note: none.