sql: fix wrong representation of SHOW JOBS #40601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
spaskob
force-pushed
the
rsg-bug
branch
2 times, most recently
from
8122446
to
24d354a
Compare
maddyblue
approved these changes
Sep 9, 2019
|
The Fixes tag is incorrect in the commit message. It should be |
`WHEN COMPLETE` was wrongly being put in the end of the string representation of `SHOW JOBS WHEN COMPLETE SELECT...` stmt. Fixes: cockroachdb#40534. Release note: None
|
Thanks Matt, fixed the incorrect commit message. |
knz
approved these changes
Sep 9, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 9, 2019
40523: opt: fix functional deps and stats for WithScanExpr r=rytaft a=rytaft This commit fixes the functional dependencies and stats calculation for `WithScanExpr` so they use the output columns rather than the input columns. Fixes #40296 Release note: None 40601: sql: fix wrong representation of SHOW JOBS r=spaskob a=spaskob `WHEN COMPLETE` was wrongly being put in the end of the string representation of `SHOW JOBS WHEN COMPLETE SELECT...` stmt. Fixes: #40534. Release note (bug fix): None Co-authored-by: Rebecca Taft <becca@cockroachlabs.com> Co-authored-by: Spas Bojanov <spas@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHEN COMPLETEwas wrongly being put in the end of the stringrepresentation of
SHOW JOBS WHEN COMPLETE SELECT...stmt.Fixes: #40534.
Release note (bug fix): None