coldata: respect SelOnDest flag when setting nulls #40606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when setting nulls, we would always set it at the offset from DestIdx. However, this is incorrect, when SelOnDest flag is true - we need to set the null at selIdx. Now this is fixed. Release note: None
|
This change is |
rafiss
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
LGTM great catch!
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 9, 2019
40606: coldata: respect SelOnDest flag when setting nulls r=yuzefovich a=yuzefovich Previously, when setting nulls, we would always set it at the offset from DestIdx. However, this is incorrect when SelOnDest flag is true - we need to set the null at selIdx. Now this is fixed. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when setting nulls, we would always set it at the offset
from DestIdx. However, this is incorrect when SelOnDest flag is true -
we need to set the null at selIdx. Now this is fixed.
Release note: None