coldata: bugfix to coldata.Copy with NULL and SelOnDest #40620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
pkg/col/coldata/vec_test.go, line 366 at r1 (raw file):
// Set up the destination vector. dst := NewMemColumn(typ, BatchSize)
[nit]: I'd mention that the vector is with all nulls except for a single non-null at the index 0.
pkg/col/coldata/vec_test.go, line 375 at r1 (raw file):
// Set up the source vector with one null. src := NewMemColumn(typ, BatchSize)
[nit]: s/one null/two nulls/ above.
pkg/col/coldata/vec_test.go, line 391 at r1 (raw file):
Src: src, SrcStartIdx: 1, SrcEndIdx: 2,
Comment below indicates that you might have intended to use SrcEndIdx: 3.
pkg/col/coldata/vec_tmpl.go, line 131 at r1 (raw file):
// } switch args.ColType {
[nit]: s/indicate/indicates/ above.
jordanlewis
force-pushed
the
copy-null-sel
branch
from
9195569
to
ae0885d
Compare
Previously, Copy always wiped all of the destination NULLs regardless of SelOnDest, which if set indiciates that only the selection vector tuples will be written to on the destinatiion side. Now, when SelOnDest is true, we don't erroneously overwrite non-selected nulls. Release note: None
jordanlewis
force-pushed
the
copy-null-sel
branch
from
ae0885d
to
99711d9
Compare
|
bors r+ |
Canceled (will resume) |
Build failed |
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 10, 2019
40620: coldata: bugfix to coldata.Copy with NULL and SelOnDest r=jordanlewis a=jordanlewis Previously, Copy always wiped all of the destination NULLs regardless of SelOnDest, which if set indiciates that only the selection vector tuples will be written to on the destination side. Now, when SelOnDest is true, we don't erroneously overwrite non-selected nulls. Release note: None Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Copy always wiped all of the destination NULLs regardless of
SelOnDest, which if set indiciates that only the selection vector tuples
will be written to on the destination side. Now, when SelOnDest is
true, we don't erroneously overwrite non-selected nulls.
Release note: None