sql: backward compat for ALTER PARTITION OF TABLE #40650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Nice catch. LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rohany)
When we made partition names index-scoped, we removed the ability to specify secondary index partitions in the ALTER PARTITION ... OF TABLE command. However I'm concerned this could break some backward compatibility. I restored that behavior but added logic to throw an error if there are multiple partitions with the same name. Fixes cockroachdb#40425 Release note: None
solongordon
force-pushed
the
partition-backward-compat
branch
from
8b057e6
to
65c5e37
Compare
|
Release justification: Low-risk update to new functionality. This adds better backwards compatibility to functionality introduced in #39332. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 11, 2019
40650: sql: backward compat for ALTER PARTITION OF TABLE r=solongordon a=solongordon When we made partition names index-scoped, we removed the ability to specify secondary index partitions in the ALTER PARTITION ... OF TABLE command. However I'm concerned this could break some backward compatibility. I restored that behavior but added logic to throw an error if there are multiple partitions with the same name. Fixes #40425 Release note: None Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we made partition names index-scoped, we removed the ability to
specify secondary index partitions in the ALTER PARTITION ... OF TABLE
command. However I'm concerned this could break some backward
compatibility. I restored that behavior but added logic to throw an
error if there are multiple partitions with the same name.
Fixes #40425
Release note: None