exec: fix a bug with ON expression support for joiners #40651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a selection vector was ignored when applying a filter on the batch. Now this is fixed. It is extremely difficult to write a unit test for this at the moment because the filter planning code lives in sql/distsqlrun. Release note: None
|
This change is |
jordanlewis
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 10, 2019
40651: exec: fix a bug with ON expression support for joiners r=yuzefovich a=yuzefovich Previously, a selection vector was ignored when applying a filter on the batch. Now this is fixed. It is extremely difficult to write a unit test for this at the moment because the filter planning code lives in sql/distsqlrun. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a selection vector was ignored when applying a filter
on the batch. Now this is fixed. It is extremely difficult to write
a unit test for this at the moment because the filter planning code
lives in sql/distsqlrun.
Release note: None