Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec: Fix NULL expression handling in CASE and AND operators #40657

Merged
merged 1 commit into from
Sep 14, 2019
Merged

exec: Fix NULL expression handling in CASE and AND operators #40657

merged 1 commit into from
Sep 14, 2019

Commits on Sep 14, 2019

  1. exec: Fix NULL expression handling in CASE and AND operators 

    This change fixes the CASE and AND operators when nulls were used as
expressions, which caused different errors than nulls existing as data
within the batches. Additionally, this change increases the safety of
the vectorized engine by disallowing the engine to plan
constNullOperators without knowing the "type" of the null to avoid
having the same panic arise. To get around this, when the "type" of the
null is known, a constNullOperator with a known type can be planned.
This is a temporary fix for the release. To be properly fixed, datum
nulls need to be aware of their type post typechecking, instead of being
"unknown".

Release justification: This PR fixes known panics within the vectorized engine.

Fixes cockroachdb#40526.

Release note: None
    Rohan Yadav committed Sep 14, 2019
    Configuration menu
    Copy the full SHA
    d3fc0c2 View commit details
    Browse the repository at this point in the history