Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: fix execbuilder output column count for lookup joins #40669

Merged
merged 1 commit into from
Sep 11, 2019

Commits on Sep 11, 2019

  1. opt: fix execbuilder output column count for lookup joins

    This commit fixes a bug in the execbuilder, which was determining
    the number of output columns incorrectly for lookup joins. In particular,
    if the join was a semi- or anti-join, the execbuilder was incorrectly
    including the right side columns in the column count. This commit
    fixes the code so it only includes left side columns for semi- and
    anti-joins.
    
    This commit also fixes a bug in the DistSQL planner that was masked
    by the bug in the execbuilder. In particular, the output types slice
    for lookup semi- and anti-joins incorrectly included the types from the
    right side columns. This commit fixes it to only include types for the
    left side columns.
    
    Fixes cockroachdb#40562
    
    Release note (bug fix): Fixed an error that could occur when the
    optimizer created a plan with a lookup semi- or anti-join nested
    inside of another join.
    rytaft committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    63b31df View commit details
    Browse the repository at this point in the history