sql: stop presplitting spans on every import proc #40676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
thoszhang
approved these changes
Sep 16, 2019
pbardea
force-pushed
the
presplit-once
branch
from
74cf99e
to
0500d6d
Compare
We are currently presplitting spans (on every table and index boundary) for every processor. We should only be doing this once so this PR moves it to the planning stage. Release justification: improves test flakes associated with too many AdminSplit requests. Release note: None
pbardea
force-pushed
the
presplit-once
branch
from
0500d6d
to
89f4cdf
Compare
|
TFTR, also thanks for testing this against to roachtest. |
Build failed (retrying...) |
Build failed |
|
Trying again... |
craig bot
pushed a commit
that referenced
this pull request
Sep 17, 2019
40676: sql: stop presplitting spans on every import proc r=pbardea a=pbardea We are currently presplitting spans (on every table and index boundary) for every processor. We should only be doing this once so this PR moves it to the planning stage. Addresses #39072. Release note: None 40838: makefile: increase test timeout r=andreimatei a=andreimatei This patch increases the test timeout for every package from 12m to 20m (and under stress from 25m to 30m). This is motivated by the sql TestLogic which has been inching towards the 12m recently (according to TeamCity history) and is sometimes timing out. Hopefully it's because we've been adding more tests... Fixes #40572 Release note: None Release justification: fix timeout flakes Co-authored-by: Paul Bardea <pbardea@gmail.com> Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently presplitting spans (on every table and index boundary)
for every processor. We should only be doing this once so this PR moves
it to the planning stage.
Addresses #39072.
Release note: None