sql: designate optimizer_foreign_keys as experimental #40689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
justinj
reviewed
Sep 11, 2019
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @awoods187 and @justinj)
RaduBerinde
force-pushed
the
fk-opt-experimental
branch
from
817f042
to
86852fc
Compare
We are not going to declare the optimizer-driven-FK production-ready in this release so this commit changes (back) the name of the session variable and cluster setting to contain the `experimental` designation. Release note: None
RaduBerinde
force-pushed
the
fk-opt-experimental
branch
from
86852fc
to
e51c7b3
Compare
rytaft
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1.
Reviewable status:
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 12, 2019
40689: sql: designate optimizer_foreign_keys as experimental r=RaduBerinde a=RaduBerinde We are not going to declare the optimizer-driven-FK production-ready in this release so this commit changes (back) the name of the session variable and cluster setting to contain the `experimental` designation. Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
|
Release justification: Category 2: Bug fixes and low-risk updates to new functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not going to declare the optimizer-driven-FK production-ready
in this release so this commit changes (back) the name of the session
variable and cluster setting to contain the
experimentaldesignation.
Release note: None