sql: add hint for ALTER PARTITION OF INDEX error #40720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user accidentally passes a table name (or some other non-existent index name) to ALTER PARTITION ... OF INDEX, they now get a helpful hint suggesting that the use the <tablename>@<indexname> syntax to specify the index. Fixes cockroachdb#39477 Release note: None
|
This change is |
|
Release justification: Low risk error messaging improvement. |
|
lgtm |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 12, 2019
40720: sql: add hint for ALTER PARTITION OF INDEX error r=solongordon a=solongordon If a user accidentally passes a table name (or some other non-existent index name) to ALTER PARTITION ... OF INDEX, they now get a helpful hint suggesting that the use the `<tablename>@<indexname>` syntax to specify the index. Fixes #39477 Release note: None Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user accidentally passes a table name (or some other non-existent
index name) to ALTER PARTITION ... OF INDEX, they now get a helpful hint
suggesting that the use the
<tablename>@<indexname>syntax to specifythe index.
Fixes #39477
Release note: None