sql: replace an internal error in EXPLAIN (DISTSQL) and EXPLAIN (VEC) #40803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
reviewed
Sep 16, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis, @knz, and @rafiss)
Currently, when we're explaining a query that has a subquery value of which is needed to construct the physical plan, we error out with an internal error. This commit replaces that stack trace with a more user-friendly message saying that explaining such a query is not supported. Release justification: Category 2: Bug fixes and low-risk updates to new functionality. Release note: None
yuzefovich
force-pushed
the
fix-explain
branch
from
2f5a09e
to
01a7d78
Compare
|
Good idea, added. TFTR! bors r=jordanlewis |
craig bot
pushed a commit
that referenced
this pull request
Sep 17, 2019
40803: sql: replace an internal error in EXPLAIN (DISTSQL) and EXPLAIN (VEC) r=jordanlewis a=yuzefovich Currently, when we're explaining a query that has a subquery value of which is needed to construct the physical plan, we error out with an internal error. This commit replaces that stack trace with a more user-friendly message saying that explaining such a query is not supported. Addresses: #40677. Release justification: Category 2: Bug fixes and low-risk updates to new functionality. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we're explaining a query that has a subquery value
of which is needed to construct the physical plan, we error out with
an internal error. This commit replaces that stack trace with a more
user-friendly message saying that explaining such a query is not
supported.
Addresses: #40677.
Release justification: Category 2: Bug fixes and low-risk updates to
new functionality.
Release note: None