Commits on Sep 18, 2019

1. opt,sql: disallow column references in ROWS/RANGE …

   Fixes cockroachdb#38286.
   
   This is a departure from the behaviour of the heuristic planner but is
   actually the same behaviour as Postgres:
   
   ```
   d=# create table x (a int primary key);
   CREATE TABLE
   d=# select rank() over (order by a range between a preceding and unbounded following) from x;
   ERROR:  argument of RANGE must not contain variables
   LINE 1: select rank() over (order by a range between a preceding and...
   ```
   
   Our behaviour now:
   ```
   root@127.0.0.1:60679/movr> CREATE TABLE x (a INT8 PRIMARY KEY)
   CREATE TABLE
   
   root@127.0.0.1:60679/movr> SELECT
       rank() OVER (ORDER BY a RANGE BETWEEN a PRECEDING AND UNBOUNDED FOLLOWING)
   FROM
       x
   pq: ROWS or RANGE cannot contain variables
   ```
   
   Release justification: Category 2: Fixes a bug and brings behaviour more
   in-line with Postgres.
   
   Release note (sql change): column references are no longer allowed in
   ROWS/RANGE clauses in window functions.

   Justin Jaffray committed Sep 18, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 7a8fdfb
   • Browse repository at this point

   Copy the full SHA

   7a8fdfb View commit details

   Browse the repository at this point in the history