cli/interactive_tests: deflake and accelerate test_multiple_nodes #40867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release justification: deflakes a test and makes CI run faster Prior to this patch the test would attempt to shut down the cluster gracefully after asserting that the 3 nodes are properly joined. Unfortunately this wait is running into separate issue cockroachdb#40834 and this makes the test clean-up flaky. Since this unit test is not about quitting a cluster but merely checking that the join is successful, this patch both works around the related issue and accelerates the test by simply killing the nodes. Release note: None
|
This change is |
andreimatei
reviewed
Sep 18, 2019
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei and @jordanlewis)
|
TFYR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 18, 2019
40867: cli/interactive_tests: deflake and accelerate test_multiple_nodes r=knz a=knz Release justification: deflakes a test and makes CI run faster Prior to this patch the test would attempt to shut down the cluster gracefully after asserting that the 3 nodes are properly joined. Unfortunately this wait is running into separate issue #40834 and this makes the test clean-up flaky. Since this unit test is not about quitting a cluster but merely checking that the join is successful, this patch both works around the related issue and accelerates the test by simply killing the nodes. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release justification: deflakes a test and makes CI run faster
Prior to this patch the test would attempt to shut down the cluster
gracefully after asserting that the 3 nodes are properly joined.
Unfortunately this wait is running into separate issue
#40834 and this makes
the test clean-up flaky.
Since this unit test is not about quitting a cluster but merely
checking that the join is successful, this patch both works around the
related issue and accelerates the test by simply killing the nodes.
Release note: None