sql: add telemetry for when distsql/vectorized is used

[rafiss]

This adds two new features that are incremented whenever a query is
executed with distsql or vectorized. The feature names are:

• sql.exec.query.is-distributed
• sql.exec.query.is-vectorized

touches #40418 and cockroachlabs/registration#227

Release justification: low impact monitoring improvement

Release note: None

[cockroach-teamcity]

This change is 

[rafiss]

I am not super sure about the feature names I choose -- let me know if another name would be better.

[rohany]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @rohany)

---

pkg/sql/sqltelemetry/exec.go, line 16 at r1 (raw file):

var (
	DistSQLExecCounter = telemetry.GetCounterOnce("sql.exec.distsql.on")

I'm not sure, but i think its better to place these in an init method? Though if there isn't any difference really then I don't have an opinion.

[rohany]

How about

sql.exec.query.is_distributed
sql.exec.query.is_vectorized

[rafiss]

thanks i like your names better

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rohany)

---

pkg/sql/sqltelemetry/exec.go, line 16 at r1 (raw file):

Previously, rohany (Rohan Yadav) wrote…

I'm not sure, but i think its better to place these in an init method? Though if there isn't any difference really then I don't have an opinion.

my understanding was that an init method is only needed when the initialization can't be done inline, like if you need a loop. i'll check out other examples

[rohany]

jk make those names have dashes, not underscores -- telemetry/doc.go style guide

[rohany]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)

---

pkg/sql/sqltelemetry/exec.go, line 16 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

my understanding was that an init method is only needed when the initialization can't be done inline, like if you need a loop. i'll check out other examples

I looked a bit more, theres a small difference -- i think this initialization always happens, while the init initialization happens only if the package is imported

[rafiss]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rohany)

---

pkg/sql/sqltelemetry/exec.go, line 16 at r1 (raw file):

Previously, rohany (Rohan Yadav) wrote…

I looked a bit more, theres a small difference -- i think this initialization always happens, while the init initialization happens only if the package is imported

ah interesting. well the convention in the sqltelemetry package seems to be to do it inline with the declaration when possible, so i guess i'll stick with that.

e.g. pkg/sql/sqltelemetry/planning.go and pkg/sql/sqltelemetry/pgwire.go

[rafiss]

ping @jordanlewis for TL sign-off

[jordanlewis]

LGTM, thank you!

[rafiss]

bors r=jordanlewis

[craig]

Build succeeded

• GitHub CI (Cockroach)