builtins: add pg_function_is_visible; pg_get_function_result #40902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
4 tasks
jordanlewis
force-pushed
the
pg-function-builtins
branch
from
da69311
to
658d973
Compare
jordanlewis
force-pushed
the
pg-function-builtins
branch
from
658d973
to
440e72b
Compare
knz
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
LGTM on idea + tests but minor nits on the implementation.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis)
pkg/sql/sem/builtins/pg_builtins.go, line 624 at r1 (raw file):
funcOid := tree.MustBeDOid(args[0]) t, err := ctx.InternalExecutor.QueryRow( ctx.Ctx(), "pg_get_function_identity_arguments",
curious: how come the string constant is different from the function name? what does "function identity arguments" mean?
pkg/sql/sem/builtins/pg_builtins.go, line 952 at r1 (raw file):
ReturnType: tree.FixedReturnType(types.Bool), Fn: func(ctx *tree.EvalContext, args tree.Datums) (tree.Datum, error) { oid := args[0]
MustBeDOid or something here
Release note (sql change): add the pg_function_is_visible and pg_get_function_result builtins. Release justification: very low risk cosmetic pg compatibility builtin
jordanlewis
force-pushed
the
pg-function-builtins
branch
from
440e72b
to
3e19d99
Compare
|
Done - both were oversights. Thanks for the review! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 20, 2019
40902: builtins: add pg_function_is_visible; pg_get_function_result r=jordanlewis a=jordanlewis Closes #33297. Closes #31737. Release note (sql change): add the pg_function_is_visible and pg_get_function_result builtins. Release justification: very low risk cosmetic pg compatibility builtin Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33297.
Closes #31737.
Release note (sql change): add the pg_function_is_visible and
pg_get_function_result builtins.
Release justification: very low risk cosmetic pg compatibility builtin