Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Add telemetry for interleaved table join #40914

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

rohany
Copy link
Contributor

@rohany rohany commented Sep 19, 2019

Adds some telemetry for how often the interleaved table join operation
gets planned, under the key "sql.plan.interleaved-table-join".

Fixes #39360.

Release justification: Low risk monitoring improvement.

Release note: None

@rohany rohany requested review from jordanlewis and a team September 19, 2019 16:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Adds some telemetry for how often the interleaved table join operation
gets planned, under the key "sql.plan.interleaved-table-join".

Fixes cockroachdb#39360.

Release justification: Low risk monitoring improvement.

Release note: None
@rohany
Copy link
Contributor Author

rohany commented Sep 24, 2019

friendly ping

Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rohany
Copy link
Contributor Author

rohany commented Sep 24, 2019

bors r=jordanlewis

@craig
Copy link
Contributor

craig bot commented Sep 24, 2019

Build failed

@rohany
Copy link
Contributor Author

rohany commented Sep 24, 2019

bors r+

looks like a test flake

craig bot pushed a commit that referenced this pull request Sep 24, 2019
40914: sql: Add telemetry for interleaved table join r=rohany a=rohany

Adds some telemetry for how often the interleaved table join operation
gets planned, under the key "sql.plan.interleaved-table-join".

Fixes #39360.

Release justification: Low risk monitoring improvement.

Release note: None

Co-authored-by: Rohan Yadav <rohany@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Sep 24, 2019

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: add telemetry for interleaved table join if it doesn't already exist
3 participants