opt: don't report invalid PruneCols from WithScan #40937
Conversation
|
This change is |
There was a problem hiding this comment.
Thanks for the quick fix!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj, @RaduBerinde, and @rytaft)
pkg/sql/opt/memo/logical_props_builder.go, line 755 at r1 (raw file):
// Things like PruneCols are not valid here. // TODO(justin): we should re-implement the relevant ones for WithScan.
[nit] I agree but this TODO doesn't really belong here - the code change wouldn't be here but in DerivePruneCols etc (we would let those functions recalculate as necessary)
Fixes cockroachdb#40930. This commit zeroes out the Rule field on the relational props copied from the With node. Follow-up for post branching will be to correctly prune the columns from the WithScan. Release note (bug fix): Fixed a stack overflow that could occur via use of WITH. Release justification: Category 2: Low risk and important bugfix.
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/sql/opt/memo/logical_props_builder.go, line 755 at r1 (raw file):
Previously, RaduBerinde wrote…
[nit] I agree but this TODO doesn't really belong here - the code change wouldn't be here but in
DerivePruneColsetc (we would let those functions recalculate as necessary)
Removed—I'll just add it to my TODO list for now
40937: opt: don't report invalid PruneCols from WithScan r=justinj a=justinj Fixes #40930. This commit zeroes out the Rule field on the relational props copied from the With node. Follow-up for post branching will be to correctly prune the columns from the WithScan. Release note (bug fix): Fixed a stack overflow that could occur via use of WITH. Release justification: Category 2: Low risk and important bugfix. Co-authored-by: Justin Jaffray <justin@cockroachlabs.com>
Build succeeded |
Fixes #40930.
This commit zeroes out the Rule field on the relational props copied
from the With node. Follow-up for post branching will be to correctly
prune the columns from the WithScan.
Release note (bug fix): Fixed a stack overflow that could occur via use
of WITH.
Release justification: Category 2: Low risk and important bugfix.