sql: fix behavior of SERIAL columns on mixed-case tables #40965
Merged
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
When `experimental_serial_normalization` is set to `sql_sequence`, there was previously an issue with mixed-case tables - the created sequence wouldn't be quoted properly. This fixes the issue. Release note (sql change): fix behavior of SERIAL columns on mixed-case tables when experimental_serial_normalization=sql_sequence. Release justification: low-risk bugfix.
jordanlewis
force-pushed
the
fix-serial-mixed-case
branch
from
4ed752c
to
7cdfbc1
Compare
arulajmani
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
LGTM
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 23, 2019
40965: sql: fix behavior of SERIAL columns on mixed-case tables r=jordanlewis a=jordanlewis Closes #40964. When `experimental_serial_normalization` is set to `sql_sequence`, there was previously an issue with mixed-case tables - the created sequence wouldn't be quoted properly. This fixes the issue. Release note (sql change): fix behavior of SERIAL columns on mixed-case tables when experimental_serial_normalization=sql_sequence. Release justification: low-risk bugfix. Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40964.
When
experimental_serial_normalizationis set tosql_sequence, therewas previously an issue with mixed-case tables - the created sequence
wouldn't be quoted properly. This fixes the issue.
Release note (sql change): fix behavior of SERIAL columns on mixed-case
tables when experimental_serial_normalization=sql_sequence.
Release justification: low-risk bugfix.