c-deps: bump rocksdb to disable TLS on Windows #40994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
petermattis
approved these changes
Sep 23, 2019
Release justification: There is a bug related to freeing up TLS memory. It results in accessing freed up memory at shutdown. This fixes it. Fixes cockroachdb#40925 Fixes cockroachdb#40936 Release note: Resolves an issue with shutting down a node with `cockroach quit` when the server is running on Windows leads to the server process hanging.
darinpp
force-pushed
the
update_rocksdb_to_8978e86
branch
from
334f79b
to
ab10150
Compare
Done. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 23, 2019
40994: c-deps: bump rocksdb to disable TLS on Windows r=darinpp a=darinpp Release justification: There is a bug related to freeing up TLS memory. It results in accessing freed up memory at shutdown. This fixes it. Fixes #40925 Fixes #40936 Release note: Resolves an issue with shutting down a node with `cockroach quit` when the server is running on Windows leads to the server process hanging. Co-authored-by: Darin <darinp@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release justification: There is a bug related to freeing up
TLS memory. It results in accessing freed up memory at shutdown.
This fixes it.
Fixes #40925
Fixes #40936
Release note: Resolves an issue with shutting down a node with
cockroach quitwhen the server is running on Windows leads tothe server process hanging.