roachtest: remove wait loop in backup2TB roachtest #41010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a wait loop was needed in the backup2TB roachtest because the test was reporting the table as offline when it shouldn't have seen it as OFFLINE. This was fixed by cockroachdb#40996, and therefore we should no longer need this wait loop. Release justification: Only touches tests. Release note: None
|
This change is |
dt
approved these changes
Oct 3, 2019
|
bors r+ |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Oct 8, 2019
41010: roachtest: remove wait loop in backup2TB roachtest r=pbardea a=pbardea Previously a wait loop was needed in the backup2TB roachtest because the test was reporting the table as offline when it shouldn't have seen it as OFFLINE. This was fixed by #40996, and therefore we should no longer need this wait loop. Closes #36841. Release justification: Only touches tests. Release note: None 41250: opt: map and push down equality conditions r=rytaft a=rytaft This commit adds a new normalization rule to enable pushing variable equality conditions such as `a.x=b.x` through joins. For example, consider this query: `SELECT * FROM a, b, c WHERE a.x=b.x AND a.x=c.x` Given join ordering `(a join (b join c))`, it should be possible to infer the filter `b.x=c.x` and push it down from the top level onto the join `(b join c)`. This commit enables that mapping and pushdown to happen. In addition, this commit updates the `AssociateJoin` rule to map as many equality conditions as possible to use the output columns of the new inner-most join, allowing those conditions to be pushed onto that join. For example, consider this query: `SELECT * FROM a, b, c WHERE a.x=b.x AND b.x=c.x` If the AssociateJoin rule creates a new join ordering `(b join (a join c))`, it should be possible to map `a.x=b.x` to `a.x=c.x` and add it onto the new inner-most join `(a join c)`. This commit enables that mapping to happen. Fixes #38716 Fixes #36226 Release note (performance improvement): Improved performance for some join queries due to improved filter inference during planning. Release justification: This commit will not be merged before the release branch is cut. Co-authored-by: Paul Bardea <pbardea@gmail.com> Co-authored-by: Rebecca Taft <becca@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a wait loop was needed in the backup2TB roachtest because the
test was reporting the table as offline when it shouldn't have seen it
as OFFLINE. This was fixed by #40996, and therefore we should no longer
need this wait loop.
Closes #36841.
Release justification: Only touches tests.
Release note: None