jobs: clean running jobs with no mutations left #41172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
spaskob
force-pushed
the
orphan-jobs
branch
from
2fed7a7
to
359bdeb
Compare
dt
reviewed
Sep 27, 2019
pkg/jobs/registry.go
Outdated
| return false, nil | ||
| } | ||
| for _, id := range payload.DescriptorIDs { | ||
| txn := r.db.NewTxn(ctx, "get_table_and_db_descrs") |
There was a problem hiding this comment.
we usually use r.db.Txn() and pass a closure, which also means you don't need to do your own retries.
spaskob
changed the title
spaskob
force-pushed
the
orphan-jobs
branch
2 times, most recently
from
c099cd2
to
20a766c
Compare
spaskob
commented
Oct 1, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @dt)
pkg/jobs/registry.go, line 375 at r1 (raw file):
Previously, dt (David Taylor) wrote…
we usually use
r.db.Txn()and pass a closure, which also means you don't need to do your own retries.
Done.
dt
reviewed
Oct 1, 2019
pkg/jobs/registry.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if len(td.GetMutations()) != 0 { |
There was a problem hiding this comment.
can just assign the bool to the if condition instead of using an if, right?
Also, this seems like the name vs definition is inverted, no?
Failures can leave jobs in orphaned state where no work needs to be done but they are left in `system.jobs` table. We detect and delete such jobs if they are too old. Touches cockroachdb#40563. Release justification: This commit is safe for 19.2 because this is a fairly low risk change since it only affects jobs that have no mutations left and that are >24h old. Release note: None.
dt
approved these changes
Oct 2, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 2, 2019
41172: jobs: clean running jobs with no mutations left r=spaskob a=spaskob Failures can leave jobs in orphaned state where no work needs to be done but they are left in `system.jobs` table. We detect and delete such jobs if they are too old. Touches #40563. Release justification: This commit is safe for 19.2 because this is a fairly low risk change since it only affects jobs that have no mutations left and that are >24h old. Release note: None. Co-authored-by: spaskob <spas@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failures can leave jobs in orphaned state where no work needs
to be done but they are left in
system.jobstable. We detectand delete such jobs if they are too old.
Touches #40563.
Release justification: This commit is safe for 19.2 because
this is a fairly low risk change since it only affects jobs that
have no mutations left and that are >24h old.
Release note: None.