Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: don't count uninitialized replicas in ReplicaCount metric #41278

Merged
merged 1 commit into from
Oct 4, 2019
Merged

storage: don't count uninitialized replicas in ReplicaCount metric #41278

merged 1 commit into from
Oct 4, 2019

Conversation

nvanbenschoten
Copy link
Member

Fixes #41271.

This was accidentally added in 2020115.

Release justification: Fixes crash.

Release note: None

@nvanbenschoten
storage: don't count uninitialized replicas in ReplicaCount metric
cd40487 
Fixes cockroachdb#41271.

This was accidentally added in 2020115.

Release justification: Fixes crash.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

ajwerner
ajwerner approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞
:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@nvanbenschoten
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 3, 2019

Build failed

@nvanbenschoten nvanbenschoten mentioned this pull request Oct 4, 2019
Closed
@nvanbenschoten
Copy link
Member Author

Logic test flake. Filed #41313.

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 4, 2019

Build failed

@nvanbenschoten
Copy link
Member Author

TestComposeGSS flake like #39444.

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 4, 2019

Build failed

@nvanbenschoten
Copy link
Member Author

Same flake.

bors r+

craig bot pushed a commit that referenced this pull request Oct 4, 2019
@nvanbenschoten
Merge #41278
d6b2379 
41278: storage: don't count uninitialized replicas in ReplicaCount metric r=nvanbenschoten a=nvanbenschoten

Fixes #41271.

This was accidentally added in 2020115.

Release justification: Fixes crash.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig
Copy link
Contributor

craig bot commented Oct 4, 2019

Build succeeded

@craig craig bot merged commit cd40487 into cockroachdb:master Oct 4, 2019
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/replCountUninit branch October 14, 2019 03:11
@knz knz mentioned this pull request Nov 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: Store.Capacity: panic: ... makeslice: cap out of range
3 participants
@nvanbenschoten @cockroach-teamcity @ajwerner