roachtest: update pgjdbc blacklist with new expected pass #41389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that used to fail now pass, so we need to update the blacklist. closes cockroachdb#41366 Release justification: test only change Release note: None
|
This change is |
|
LGTM |
|
bors r+ |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Oct 8, 2019
41031: roachprod: Add support for Microsoft Azure cloud r=bobvawter a=bobvawter This commit adds support for geodistributed roachprod clusters running on Azure VMs. Refer to the azure/doc.go package comments for additional information about how the deployment operates. Release note: None 41389: roachtest: update pgjdbc blacklist with new expected pass r=rafiss a=rafiss Tests that used to fail now pass, so we need to update the blacklist. closes #41366 Release justification: test only change Release note: None Co-authored-by: Bob Vawter <bob@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
|
Hmmmm well I guess it's lucky that the bors merge failed, because the test is now back to failing, as was expected before. Leaving this PR open for now in case we need to bring it back again. |
|
bors r+ |
|
re-submitting, seems like these two tests are passing reliably now https://teamcity.cockroachdb.com/viewLog.html?buildId=1531418&tab=artifacts#/pgjdbc |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that used to fail now pass, so we need to update the blacklist.
closes #41366
Release justification: test only change
Release note: None