backupccl: fix sanitizeLocalityKV() char handling #41479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes `sanitizeLocalityKV()`, which sanitizes locality KV strings so they can be used in filepaths for partitioned backups, and was using the wrong bounds to check for alphanumeric characters. Release justification: This is a minor low-risk fix for a bug in a new feature. Release note: None
|
This change is |
dt
approved these changes
Oct 9, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 10, 2019
41479: backupccl: fix sanitizeLocalityKV() char handling r=lucy-zhang a=lucy-zhang This PR fixes `sanitizeLocalityKV()`, which sanitizes locality KV strings so they can be used in filepaths for partitioned backups, and was using the wrong bounds to check for alphanumeric characters. Release justification: This is a minor low-risk fix for a bug in a new feature. Release note: None Co-authored-by: Lucy Zhang <lucy-zhang@users.noreply.github.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
sanitizeLocalityKV(), which sanitizes locality KV strings sothey can be used in filepaths for partitioned backups, and was using the wrong
bounds to check for alphanumeric characters.
Release justification: This is a minor low-risk fix for a bug in a new feature.
Release note: None