release-19.2: storage: treat non-voter replicas as suspect for replica GC #41633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a GC It is not clear that this is actually a problem but it seems like a good thing to do. We can imagine cases where a replica is removed but never receives the message which removes it from the range. In this case we could wait up to 10 days before removing the range. The VOTER_INCOMING case seems like even less of a problem but there's not an obvious reason to be conservative here. Release note: None
|
This change is |
tbg
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #41414.
/cc @cockroachdb/release
It is not clear that this is actually a problem but it seems like a good thing
to do. We can imagine cases where a replica is removed but never receives the
message which removes it from the range. In this case we could wait up to
10 days before removing the range. The VOTER_INCOMING case seems like even
less of a problem but there's not an obvious reason to be conservative here.
Release note: None