Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.2: libroach: bump up rocksdb backpressure limits #41767

Merged
merged 1 commit into from
Oct 21, 2019

Commits on Oct 21, 2019

  1. libroach: bump up rocksdb backpressure limits

    System-critical writes in Cockroach, like node-liveness, just can not be
    slow or they will fail, meaning that if theese rocksdb back-pressure
    slowdowns ever kick in, they usually do not gradually slow traffic
    until the system reaches some stable throughput equilibrium as intended,
    but rather cause liveness to fail and result in sudden  unavailability
    -- the opposite of what they were intended to do.
    
    Thus we are probably better off just letting the metrics they were
    intended to protect -- like read-amplification or compaction debt --
    stray further into unhealthy territory, than we are back-pressuring and
    hastening our demise: slower reads due to elevated read-amp are still
    better than no reads due to node-liveness failures (and indeed slower
    reads may serve as their own backpressure as we usually need to read to
    write).
    
    Release note: None
    dt committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    7c7875e View commit details
    Browse the repository at this point in the history