sql/mutations: begin work on multi-statement mutations #42298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
This is the beginning of how we might support multi-statement mutators. |
rohany
suggested changes
Nov 8, 2019
|
|
||
| // Check if a table has the needed column types. | ||
| LoopTable: | ||
| for refTable, refCols := range cols { |
There was a problem hiding this comment.
I found an error that showed up in my ci (I think i sent it to you already), but i don't think you can use the same column in multiple foreign key constraints? This threw an error in some randomly generated create table statement.
There was a problem hiding this comment.
I added a commit to address this. PTAL.
|
Reviewable isn't showing me the whole pr for some reason, so left some comments on the github reviewer |
This allows for users to choose when to use it during RandCreateTables. Release note: None
|
LGTM |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.