storage/engine: fix pebbleExportToSst behavior on empty sstables #42599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `pebbleExportToSst` to return a `nil` sstable if the no records were added. The previous behavior was a minor behavioral difference from the C++ version of `ExportToSst` which caused `TestRandomKeyAndTimestampExport` to be flaky when run on Pebble. Release note: None
|
This change is |
itsbilal
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajkr and @sumeerbhola)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 20, 2019
42599: storage/engine: fix pebbleExportToSst behavior on empty sstables r=petermattis a=petermattis Fix `pebbleExportToSst` to return a `nil` sstable if the no records were added. The previous behavior was a minor behavioral difference from the C++ version of `ExportToSst` which caused `TestRandomKeyAndTimestampExport` to be flaky when run on Pebble. Release note: None Co-authored-by: Peter Mattis <petermattis@gmail.com>
Build succeeded |
petermattis
deleted the
pmattis/deflake-test-random-key-and-timestamp-export
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
pebbleExportToSstto return anilsstable if the no records wereadded. The previous behavior was a minor behavioral difference from the
C++ version of
ExportToSstwhich causedTestRandomKeyAndTimestampExportto be flaky when run on Pebble.Release note: None