sql: complete eval functionality for TimeTZ #42687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
otan-timetz_operations
branch
2 times, most recently
from
1fcd27c
to
5a70310
Compare
solongordon
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan)
pkg/sql/sem/tree/eval.go, line 611 at r1 (raw file):
return nil, err } t := leftTime.Add(right.(*DTimeTZ).ToTime().Sub(timeutil.Unix(0, 0)))
Minor: The .Sub(timeutil.Unix(0, 0)) bit is a little mysterious. It might be nicer to add a ToDuration method on TimeOfDay or something.
otan
force-pushed
the
otan-timetz_operations
branch
2 times, most recently
from
c79e5f5
to
f2ffb41
Compare
We want to support all operations that are supported by TimeTZ in
postgres:
* equality, less than
* timetz + date, interval + timetz
* timetz + interval, interval + timetz
* timetz - interval
```
otan=# select oprname, oprcode from pg_operator
where oprleft = 'timetz'::regtype or oprright = 'timetz'::regtype
or oprresult = 'timetz'::regtype;
oprname | oprcode
---------+--------------------
= | timetz_eq
<> | timetz_ne
< | timetz_lt
<= | timetz_le
> | timetz_gt
>= | timetz_ge
+ | datetimetz_pl
+ | timetzdate_pl
+ | timetz_pl_interval
- | timetz_mi_interval
+ | interval_pl_timetz
(11 rows)
```
Release note: None
otan
force-pushed
the
otan-timetz_operations
branch
from
f2ffb41
to
d062297
Compare
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 3, 2019
42687: sql: complete eval functionality for TimeTZ r=otan a=otan Refs: #26097 We want to support all operations that are supported by TimeTZ in postgres: * equality, less than * timetz + date, interval + timetz * timetz + interval, interval + timetz * timetz - interval ``` otan=# select oprname, oprcode from pg_operator where oprleft = 'timetz'::regtype or oprright = 'timetz'::regtype or oprresult = 'timetz'::regtype; oprname | oprcode ---------+-------------------- = | timetz_eq <> | timetz_ne < | timetz_lt <= | timetz_le > | timetz_gt >= | timetz_ge + | datetimetz_pl + | timetzdate_pl + | timetz_pl_interval - | timetz_mi_interval + | interval_pl_timetz (11 rows) ``` Release note: None Co-authored-by: Oliver Tan <otan@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #26097
We want to support all operations that are supported by TimeTZ in
postgres:
Release note: None