Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: removed redundant activeVersion argument #43011

Merged
merged 1 commit into from
Dec 11, 2019
Merged

storage: removed redundant activeVersion argument #43011

merged 1 commit into from
Dec 11, 2019

Conversation

irfansharif
Copy link
Contributor

Clean up all comments/plumbed instances of the activeVersion passed
through.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@irfansharif
storage: removed redundant activeVersion argument
c658b70 
Clean up all comments/plumbed instances of the activeVersion passed
through.

Release note: None
@irfansharif
Copy link
Contributor Author

Flaked on #42978, rebased.

nvanbenschoten
nvanbenschoten approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@irfansharif
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 10, 2019

Build failed

@irfansharif
Copy link
Contributor Author

bors retry

craig bot pushed a commit that referenced this pull request Dec 11, 2019
@irfansharif
Merge #43011
c7fe530 
43011: storage: removed redundant activeVersion argument r=irfansharif a=irfansharif

Clean up all comments/plumbed instances of the activeVersion passed
through.

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
@craig
Copy link
Contributor

craig bot commented Dec 11, 2019

Build succeeded

@craig craig bot merged commit c658b70 into cockroachdb:master Dec 11, 2019
@irfansharif irfansharif deleted the 191205.redundant-activeVersion branch December 19, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvanbenschoten nvanbenschoten nvanbenschoten approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irfansharif @cockroach-teamcity @nvanbenschoten