sql: fix current_timestamp behaviour with time zone set #43012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
With time zones set, current_timestamp needs to localise to the timezone set in the context for time options, e.g. for `TIME` with `UTC+3` at `UTC midngiht`, `current_timestamp()` should return `3am`. This was previously not handled correctly by Timestamp, and is rectified in this PR. Release note (bug fix): Previously, current_timestamp would not correctly account for `SET TIME ZONE` in the background when storing results, storing the timestamp as `UTC` instead. This is fixed in this PR.
otan
force-pushed
the
current_timestamp_fix
branch
from
4532708
to
b78a228
Compare
solongordon
approved these changes
Dec 6, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 6, 2019
42928: builtins: add CURRENT_TIME functionality r=otan a=otan Resolves #31708 Refs #26097 This PR adds CURRENT_TIME as a builtin. Release note (sql change): This PR adds the CURRENT_TIME builtin, which can be used with precision, e.g. `SELECT CURRENT_TIME, CURRENT_TIME(3)`. 43012: sql: fix current_timestamp behaviour with time zone set r=otan a=otan With time zones set, current_timestamp needs to localise to the timezone set in the context for time options, e.g. for `TIME` with `UTC+3` at `UTC midnight`, `current_timestamp()` should return `3am`. This was previously not handled correctly by Timestamp, and is rectified in this PR. Release note (bug fix): Previously, current_timestamp would not correctly account for `SET TIME ZONE` in the background when storing results, storing the timestamp as `UTC` instead. This is fixed in this PR. Co-authored-by: Oliver Tan <otan@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With time zones set, current_timestamp needs to localise to the timezone
set in the context for time options, e.g. for
TIMEwithUTC+3atUTC midnight,current_timestamp()should return3am. This waspreviously not handled correctly by Timestamp, and is rectified in this
PR.
Release note (bug fix): Previously, current_timestamp would not
correctly account for
SET TIME ZONEin the background when storingresults, storing the timestamp as
UTCinstead. This is fixed in thisPR.