Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: update Hibernate and psycopg blacklists #43075

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Dec 10, 2019

Hibernate now has no expected failures with our dialect, and psycopg has
one fewer expected failure.

closes #42819
closes #42434

Release note: None

Hibernate now has no expected failures with our dialect, and psycopg has
one fewer expected failure.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@rafiss
Copy link
Collaborator Author

rafiss commented Dec 10, 2019

thanks!
bors r+

craig bot pushed a commit that referenced this pull request Dec 10, 2019
40258: Diagram changes for documentation r=ericharmeling a=ericharmeling

Added changes to `diagrams.go` for the following statements:
- `SHOW PARTITIONS`
- `SHOW LOCALITY` (this change is a little hacky due to the fact that `SHOW LOCALITY` is, in fact, not defined in the SQL grammar... see #39058)
- `SHOW CREATE TABLE AS`
- `SHOW COLUMNS` (`WITH COMMENT`)
- `SHOW DATABASES` (`WITH COMMENT`)

@mjibson Adding you as reviewer because you created this generator.

Release note (docs): none

43075: roachtest: update Hibernate and psycopg blacklists r=rafiss a=rafiss

Hibernate now has no expected failures with our dialect, and psycopg has
one fewer expected failure.

closes #42819
closes #42434 

Release note: None

Co-authored-by: Eric Harmeling <eric.harmeling@cockroachlabs.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Dec 10, 2019

Build succeeded

@craig craig bot merged commit 56396d4 into cockroachdb:master Dec 10, 2019
@rafiss rafiss deleted the blacklist-updates branch January 27, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: psycopg failed roachtest: hibernate failed
3 participants