Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/engine: small logging fixes #43240

Merged

Commits on Dec 17, 2019

  1. storage/engine: small logging fixes

    Change `Pebble.GetCompactionStats` to be prefixed with a newline to
    match the formatting of RocksDB. This ensures that the compaction stats
    display will not contain the log prefix which was misaligning the table
    header.
    
    Adding a missing sort to `Pebble.GetSSTables`. This was causing the
    sstable summary log message to be much busier than for RocksDB because
    `SSTableInfos.String` expects the infos to be sorted.
    
    Move the formatting of `estimated_pending_compaction_bytes: x` into
    `RocksDB.GetCompactionStats`. The Pebble compaction stats already
    included this and it is useful to see the estimated pending compaction
    bytes whenever the compaction stats are output.
    
    Release note: None
    petermattis committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    e5ed1be View commit details
    Browse the repository at this point in the history