sql/parser: parse FOR UPDATE lock wait policies #43868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit adds parsing-only support for the SKIP LOCKED and NOWAIT lock wait policies that accompany the FOR UPDATE locking strength specifiers. These are still rejected with unimplemented errors, but they now at least make it to the optimizer, where we can make a better decision about what to do with them. Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/lockWaitPolicy
branch
from
776d308 to
04aaabc
Compare
knz
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 10, 2020
43868: sql/parser: parse FOR UPDATE lock wait policies r=nvanbenschoten a=nvanbenschoten This commit adds parsing-only support for the SKIP LOCKED and NOWAIT lock wait policies that accompany the FOR UPDATE locking strength specifiers. These are still rejected with unimplemented errors, but they now at least make it to the optimizer, where we can make a better decision about what to do with them. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
sumeerbhola
reviewed
Jan 16, 2020
There was a problem hiding this comment.
Do you imagine that we would ever implement SKIP LOCKED, despite it dangerously providing an inconsistent view of the data?
Reviewable status:
nvanbenschoten
commented
Jan 16, 2020
There was a problem hiding this comment.
I doubt we will want to implement it unless we find serious customer desire for the feature. NO WAIT seems like a more reasonable alternate wait policy, so I can imagine us implementing that at some point.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds parsing-only support for the SKIP LOCKED and NOWAIT
lock wait policies that accompany the FOR UPDATE locking strength
specifiers. These are still rejected with unimplemented errors, but
they now at least make it to the optimizer, where we can make a
better decision about what to do with them.
Release note: None