sem/tree: fix LIKE ESCAPE when the pattern contains Unicode symbols #44633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
solongordon
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @solongordon and @yuzefovich)
pkg/sql/sem/tree/testdata/eval/like, line 423 at r1 (raw file):
like_escape('a', '꧕', '�') ---- false
Would it be useful to add a positive test case here too?
Previously, we were incorrectly updating the pattern when the current character was Unicode symbol that had the width of more than a single byte. Release note (bug fix): Previously, running a query with LIKE operator using custom ESCAPE symbol when the pattern contained Unicode characters could result in an internal error in CockroachDB, and now this has been fixed.
yuzefovich
force-pushed
the
fix-like-escape
branch
from
24194b7
to
f25c845
Compare
yuzefovich
commented
Feb 3, 2020
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/sql/sem/tree/testdata/eval/like, line 423 at r1 (raw file):
Previously, solongordon (Solon) wrote…
Would it be useful to add a positive test case here too?
It can't hurt, done.
craig bot
pushed a commit
that referenced
this pull request
Feb 3, 2020
43047: client,kv: new savepoint API r=andreimatei a=knz This patch introduces the KV savepoint API as discussed in the savepoints RFC: ```go // CreateSavepoint establishes a savepoint. // This method is only valid when called on RootTxns. CreateSavepoint(context.Context) (SavepointToken, error) // RollbackToSavepoint rolls back to the given savepoint. The // savepoint must not have been rolled back or released already. // All savepoints "under" the savepoint being rolled back // are also rolled back and their token must not be used any more. // This method is only valid when called on RootTxns. RollbackToSavepoint(context.Context, SavepointToken) error // ReleaseSavepoint releases the given savepoint. The savepoint // must not have been rolled back or released already. // All savepoints "under" the savepoint being released // are also released and their token must not be used any more. // This method is only valid when called on RootTxns. ReleaseSavepoint(context.Context, SavepointToken) error ``` Ths initial implementation does not (yet) enable clients to roll back over errors. Release note: None 44626: workload/tpch: unskip query 12 r=yuzefovich a=yuzefovich Previously, query 12 was skipped because the results returned by lib/pq didn't match the expected output. The issue is that the driver returned []byte for decimals whereas we expected a string value and `fmt.Sprint` was giving us the ASCII codes of the digits instead of printing out the number. This is fixed by checking whether the returned value is []byte, and if so, converting it to string directly. Release note: None 44633: sem/tree: fix LIKE ESCAPE when the pattern contains Unicode symbols r=yuzefovich a=yuzefovich Previously, we were incorrectly updating the pattern when the current character was Unicode symbol that had the width of more than a single byte. Fixes: #44621. Release note (bug fix): Previously, running a query with LIKE operator using custom ESCAPE symbol when the pattern contained Unicode characters could result in an internal error in CockroachDB, and now this has been fixed. Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were incorrectly updating the pattern when the current
character was Unicode symbol that had the width of more than a single
byte.
Fixes: #44621.
Release note (bug fix): Previously, running a query with LIKE operator
using custom ESCAPE symbol when the pattern contained Unicode characters
could result in an internal error in CockroachDB, and now this has been
fixed.