roachtest: deflake acceptance/version-upgrade #47690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a workaround that wasn't necessary any more (since I regenerated the fixtures last week) but which caused flakes of its own because it was re-uploading the binary for predecessorVersion while processes were running using that binary (resulting in occasional 'text file busy' on linux). Closes cockroachdb#44732. Touches cockroachdb#47024. Release note: None
|
This change is |
spaskob
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
lgtm
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @spaskob)
|
TFTR! bors r=spaskob |
Build failed |
|
Timed out on a gossip-related roachtest. I think the test flaked and then the consistency check got stuck forever. I'll send a PR for that. bors r=spaskob |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a workaround that wasn't necessary any more (since I regenerated
the fixtures last week) but which caused flakes of its own because it
was re-uploading the binary for predecessorVersion while processes were
running using that binary (resulting in occasional 'text file busy' on
linux).
Closes #44732.
Touches #47024.
Release note: None