sqlbase: avoid decode/encode in Fingerprint #47728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I noticed this while taking a look at one of the heap profiles from the tpcc check OOM that @yuzefovich has been fighting:
|
yuzefovich
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Huh, I thought those allocations were expected 🤷♂️
Nice catch!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rohany)
|
Wow, nice catch! Can you stick a short comment about why we don't call ensure decoded at the top of the method? Maybe this will help the alterpk roachtest! |
|
Could you add a separate commit here to unskip |
The Fingerprint method introduced in b08d8f4 added an unnecessary decode/encode cycle that didn't exist before, if the input Datum was already in ASCENDING_KEY encoding. This commit restores the original behavior. We should probably backport this to release-20.1. Release note: None
Release note: None
jordanlewis
force-pushed
the
avoid-decode
branch
from
9bff2ca
to
e963949
Compare
|
TFTRs, both done. bors r+ |
Build succeeded |
|
We should backport this to 20.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fingerprint method introduced in
b08d8f4 added an unnecessary
decode/encode cycle that didn't exist before, if the input Datum was
already in ASCENDING_KEY encoding.
This commit restores the original behavior.
We should probably backport this to release-20.1.
Release note: None