cli: fix cockroach dump with collated strings
#48687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#48278. Release note (bug fix): Fix a bug where `cockroach dump` on a table with collated strings would omit the collation clause for the data insertion statements.
|
This change is |
dt
approved these changes
May 13, 2020
|
bors r=dt |
|
Thank! Long-term do you think it'd make sense to move some of this type-switch stuff into helpers in SQL for dump to call into? |
|
yeah most likely -- I think that was the aim of the various roundtripping work i did a few months ago |
Build succeeded |
This was referenced May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48278.
Release note (bug fix): Fix a bug where
cockroach dumpon a tablewith collated strings would omit the collation clause for the data
insertion statements.