settings: fix RegisterPublicNonNegativeDurationSettingWithMaximum #48758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
approved these changes
May 12, 2020
|
bors r=rohany |
|
❌ The GitHub CI (Cockroach) build has failed on 8fadaa14. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Build failed |
`RegisterPublicNonNegativeDurationSettingWithMaximum` should include the maximum. Seems broken by `ac3c72339b82d9f85fd8112977a542b87fb5e712`. Release note (bug fix): Re-allow `diagnostics.forced_sql_stat_reset.interval`, `diagnostics.sql_stat_reset.interval` and `external.graphite.interval` to set to their maximum values (24hr, 24hr and 15min respectively). This previously only excluded these values to be allowed.
|
❌ The GitHub CI (Cockroach) build has failed on 41055e9a. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
bors r=rohany |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegisterPublicNonNegativeDurationSettingWithMaximumshould include themaximum. Seems broken by
ac3c72339b82d9f85fd8112977a542b87fb5e712.Resolves #48337.
Release note (bug fix): Re-allow
diagnostics.forced_sql_stat_reset.interval,diagnostics.sql_stat_reset.intervalandexternal.graphite.intervalto set to their maximum values (24hr, 24hr and 15min respectively). This
previously only excluded these values to be allowed.