Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump pebble to af0d71572c7bd24deb066d09eee646b6cb7460a4 #49285

Merged
merged 1 commit into from
May 20, 2020

Conversation

petermattis
Copy link
Collaborator

  • internal/private: ratchet visible sequence number too
  • internal/rate: add Limiter.Delay{,N}
  • db: refactor tableCache.estimateDiskUsage into withReader
  • internal/cache: optimize common case of Cache.Delete()
  • internal/cache: remove weak cache handles
  • internal/randvar: optimize Uniform.IncMax
  • internal/{manual,rawalloc}: remove empty assembly files
  • internal/replay: assign ingested tables correct sequence number
  • db: wait for pending writes during ingestion
  • db: replace tableCacheShard LRU with CLOCK-Pro
  • internal/randvar: reduce exclusive locks in randvar
  • cmd/pebble: miscellaneous ycsb benchmark improvements
  • internal/rate: change Reserve{,N} to return a value

Fixes #49154

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @itsbilal)

* internal/private: ratchet visible sequence number too
* internal/rate: add Limiter.Delay{,N}
* db: refactor tableCache.estimateDiskUsage into withReader
* internal/cache: optimize common case of Cache.Delete()
* internal/cache: remove weak cache handles
* internal/randvar: optimize Uniform.IncMax
* internal/{manual,rawalloc}: remove empty assembly files
* internal/replay: assign ingested tables correct sequence number
* db: wait for pending writes during ingestion
* db: replace tableCacheShard LRU with CLOCK-Pro
* internal/randvar: reduce exclusive locks in randvar
* cmd/pebble: miscellaneous ycsb benchmark improvements
* internal/rate: change Reserve{,N} to return a value

Fixes cockroachdb#49154

Release note: None
@petermattis
Copy link
Collaborator Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented May 20, 2020

Build failed

@petermattis
Copy link
Collaborator Author

SQL logictest failures that look unrelated to this PR. Retrying.

bors r+

@craig
Copy link
Contributor

craig bot commented May 20, 2020

Merge conflict (retrying...)

@otan
Copy link
Contributor

otan commented May 20, 2020

(you have won the race, i can wait)

@craig
Copy link
Contributor

craig bot commented May 20, 2020

Build failed (retrying...)

@petermattis
Copy link
Collaborator Author

no inbound stream connection in acceptance/version-upgrade. See #47024

bors r+

@craig
Copy link
Contributor

craig bot commented May 20, 2020

Already running a review

@otan
Copy link
Contributor

otan commented May 20, 2020

o_o

bors r+

edit: nvm can't read

@craig
Copy link
Contributor

craig bot commented May 20, 2020

Already running a review

@craig
Copy link
Contributor

craig bot commented May 20, 2020

Build succeeded

@craig craig bot merged commit 1bd13e7 into cockroachdb:master May 20, 2020
@petermattis petermattis deleted the pmattis/bump-pebble branch May 20, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: acceptance/build-analyze failed
4 participants