release-20.1: opt: pass Const type explicitly #49331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Const` operator infers its type using `Datum.ResolvedType()`. The Datum's type loses information in some cases (e.g. see cockroachdb#48563). We now pass the type explicitly to `ConstructConst`, similar to the `Null` operator. Since Const already had a private member, optgen needed to be modified to tolerate a Typ field in this case (only allowed for Scalars). Note that this field was already special - for any Scalar that doesn't have a `Typ` field, one is added automatically and `InferType` is used to populate it. Release note: None
|
This change is |
RaduBerinde
approved these changes
May 21, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #48652.
/cc @cockroachdb/release
The
Constoperator infers its type usingDatum.ResolvedType(). The Datum'stype loses information in some cases (e.g. see #48563). We now pass the type
explicitly to
ConstructConst, similar to theNulloperator.Since Const already had a private member, optgen needed to be modified to
tolerate a Typ field in this case (only allowed for Scalars). Note that this
field was already special - for any Scalar that doesn't have a
Typfield, oneis added automatically and
InferTypeis used to populate it.Release note: None