rpc: *almost* use tenant client certs #51498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently unused, but already initialized correctly: it's always SystemTenantID except on SQL tenant servers, where it's the tenant's ID. Release note: None
I worried for a short while that this would always return nil, but it does not. Release note: None
This makes sure that a certificate manager for an `rpc.Context` for a given tenant is aware of the tenant ID. This is not used yet, but a new TODO (to be addressed shortly) hints at where this will be used during dialing: when we're a tenant, use the tenant client certs instead of the client certs. Release note: None
I had previously made sure that the multi-tenancy certs were in a different subdirectory, but in hindsight this is not worth the hassle. Release note: None
As of this commit, tenants would use their proper tenant client certs if it weren't for a manual override that was added. This override exists because the KV layer can not yet authenticate tenant client certs (this will change soon, in a follow-up to cockroachdb#50503). However, uncommenting both the override and the hack in `pkg/security/securitytest/test_certs/regenerate.sh` to make the tenant client certs match those used by the KV nodes gives early validation that this "will work" once the KV side plays ball. Touches cockroachdb#47898. Release note: None
|
This change is |
|
Subsumed into #51503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the last commit, tenants would use their proper tenant client certs if it
weren't for a manual override that was added.
This override exists because the KV layer can not yet authenticate
tenant client certs (this will change soon, in a follow-up to #50503).
However, uncommenting both the override and the hack in
pkg/security/securitytest/test_certs/regenerate.shto make the tenantclient certs match those used by the KV nodes gives early validation
that this "will work" once the KV side plays ball.
Touches #47898.