tree: cast TIMESTAMP to TEXT without timezone data #51692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Can you explain in the release note (perhaps anotherone with category 'cli change') what the expected change is in the CLI shell. |
|
No cli change. They will appear the same unless you cast it to text.
…On Wed, 22 Jul 2020, 2:48 am kena, ***@***.***> wrote:
Can you explain in the release note (perhaps anotherone with category 'cli
change') what the expected change is in the CLI shell.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#51692 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA32FQ3ZCGMUGDEHQQPBYNTR42YWRANCNFSM4PEH2E3Q>
.
|
otan
force-pushed
the
fix_cast_timestamp
branch
2 times, most recently
from
a97f73d to
f77d857
Compare
This better matches postgres. I'm guessing it used to be done this way to match the CLI output (which we can't fix without changing lib/pq), but this affects output results from ORM tests. Note that CLI output is not affected unless TIMESTAMP is cast to text. Release note (sql change): Casting TIMESTAMP types to TEXT related types now omits the timezone component. For example, '2001-12-15 15:14:13'::TIMESTAMP will now format as '2001-12-15 15:14:13' instead of '2001-12-15 15:14:13+00:00'.
rohany
approved these changes
Jul 22, 2020
adityamaru
approved these changes
Jul 22, 2020
|
TFTR! bors r=rohany,adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This better matches postgres. I'm guessing it used to be done this way
to match the CLI output (which we can't fix without changing lib/pq),
but this affects output results from ORM tests. Note that CLI output is
not affected unless TIMESTAMP is cast to text.
Release note (sql change): Casting TIMESTAMP types to TEXT related types
now omits the timezone component. For example, '2001-12-15
15:14:13'::TIMESTAMP will now format as '2001-12-15 15:14:13' instead of
'2001-12-15 15:14:13+00:00'.